Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructor for creating portForwardEntry #2648

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Add constructor for creating portForwardEntry #2648

merged 2 commits into from
Aug 14, 2019

Conversation

priyawadhwa
Copy link
Contributor

This should make development on port forwarding a bit easier, so that
additions to portForwardEntry don't require mulitple changes in
integration tests.

Part of #2596

Add constructor for creating portForwardEntry
3bedf5c 
This should make development on port forwarding a bit easier, so that
additions to portForwardEntry don't require mulitple changes in
integration tests.
@priyawadhwa priyawadhwa mentioned this pull request Aug 14, 2019
Closed
@codecov
Copy link

codecov bot commented Aug 14, 2019 •
edited
Loading

Codecov Report

Merging #2648 into master will increase coverage by 0.52%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
...kubernetes/portforward/port_forward_integration.go 0% <0%> (ø) ⬆️
...ffold/kubernetes/portforward/port_forward_entry.go 100% <100%> (ø) ⬆️
...g/skaffold/kubernetes/portforward/pod_forwarder.go 85.48% <100%> (-1.48%) ⬇️
...ffold/kubernetes/portforward/resource_forwarder.go 54.16% <100%> (-1.84%) ⬇️
cmd/skaffold/app/cmd/config/util.go 54.28% <0%> (-5.07%) ⬇️
pkg/skaffold/deploy/kustomize.go 72.32% <0%> (-1.76%) ⬇️
pkg/skaffold/deploy/kubectl.go 65.51% <0%> (-1.45%) ⬇️
pkg/skaffold/event/event.go 88.59% <0%> (-1.21%) ⬇️
pkg/skaffold/deploy/helm.go 66.54% <0%> (-1%) ⬇️
cmd/skaffold/app/cmd/runner.go 69.23% <0%> (ø) ⬆️
... and 16 more

@priyawadhwa priyawadhwa merged commit 443bcdc into GoogleContainerTools:master Aug 14, 2019
@priyawadhwa priyawadhwa deleted the constructor branch August 14, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyawadhwa @tejal29 @googlebot